fix: Incorrect configuration information read #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeqvip
requested changes
Jun 10, 2022
| @@ -29,7 +29,7 @@ protected function init() | |||
| */ | |||
| protected function getDbConfig(): array | |||
| { | |||
| $default = config('tauthz.database.connection') ?: config('database.default'); | |||
| $default = config('tauthz.enforcers.basic.database.connection') ?: config('database.default'); | |||
|
|
|||
| $config = config("database.connections.{$default}"); | |||
|
|
|||
There was a problem hiding this comment.
@zhangyue0503 First you should get the default enforcer, and then get the database.connection in it.
$default = config('tauthz.default');
$connection = config("tauthz.enforcers.{$default}.database.connection") ?: config('database.default');
$config = config("database.connections.{$connection}");
@zhangyue0503 You seem to have forgotten to modify the last line of code. |
leeqvip
approved these changes
Jun 11, 2022
|
🎉 This PR is included in version 1.5.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
读取配置信息键名有问题
不过读对了也没用，think-migration 有问题，已经向那边提交了 issue 数据库迁移脚本向不同的连接库迁移问题